packages/opentelemetry-instrumentation-google-generativeai/pyproject.toml (1)

28-33: Ruff added – legacy linter references still present in generator templates
Several of our project‐scaffolding templates continue to reference flake8 and autopep8. You’ll need to remove or replace these entries so that newly generated projects use only ruff. Found occurrences in:

• plugin/package/src/generators/uv-project/test/custom-template/pyproject.toml (autopep8==1.5.7)
• plugin/package/src/generators/uv-project/files/base/pyproject.toml
  • autopep8>=…
  • conditional blocks for flake8
  • commented plugins (# flake8-bugbear, # flake8-simplify)
• plugin/package/src/generators/poetry-project/files/base/pyproject.toml
  • autopep8 = “…”
  • conditional blocks for flake8
  • commented plugins (# flake8-bugbear, # flake8-simplify)
• plugin/package/src/generators/project/files/pyproject.toml
  • flake8 = “4.0.1” and several flake8-* plugins
  • autopep8 = “1.5.7”
• plugin/package/src/generators/poetry-project/test/custom-template/pyproject.toml (autopep8)

Please update these templates (and any related CI/config files) to drop flake8/autopep8 in favor of ruff.

packages/opentelemetry-instrumentation-langchain/project.json (1)

5-5: Incorrect sourceRoot – points to the Anthrop(ic) package

"opentelemetry_instrumentation_anthropic" is clearly a copy-paste error and will break Nx source-set resolution, affected lint/file-watch tasks, and IDE navigation for this package.

-  "sourceRoot": "packages/opentelemetry-instrumentation-langchain/opentelemetry_instrumentation_anthropic",
+  "sourceRoot": "packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain",

packages/opentelemetry-instrumentation-mcp/pyproject.toml (1)

29-32: Same Ruff version pin as in the replicate package

See previous comment – the rationale and diff apply verbatim.

packages/opentelemetry-instrumentation-cohere/pyproject.toml (1)

32-35: Same Ruff version pin as in the replicate package

See earlier note about upgrading from 0.12.x to the current 0.4.x stream.

packages/opentelemetry-instrumentation-haystack/pyproject.toml (1)

32-35: Same Ruff version pin as in the replicate package

Refer to the first comment for details and the suggested diff.

packages/opentelemetry-instrumentation-openai/pyproject.toml (1)

32-34: Same note as above – ensure obsolete lint deps are fully removed.

packages/opentelemetry-instrumentation-sagemaker/pyproject.toml (1)

28-30: Same note as above – ensure obsolete lint deps are fully removed.

packages/opentelemetry-semantic-conventions-ai/pyproject.toml (1)

27-30: Same note as above – ensure obsolete lint deps are fully removed.

packages/opentelemetry-instrumentation-llamaindex/pyproject.toml (1)

33-35: Same note as above – ensure obsolete lint deps are fully removed.

packages/opentelemetry-instrumentation-pinecone/pyproject.toml (1)

33-33: Same Ruff-version concern as noted for the CrewAI package

See earlier comment about upgrading / deduplicating the ruff = "^0.12.7" declaration.

packages/opentelemetry-instrumentation-anthropic/pyproject.toml (1)

33-33: Same Ruff-version concern as noted for the CrewAI package

See earlier comment about upgrading / deduplicating the ruff = "^0.12.7" declaration.

packages/opentelemetry-instrumentation-mistralai/pyproject.toml (1)

29-29: Same Ruff-version concern as noted for the CrewAI package

See earlier comment about upgrading / deduplicating the ruff = "^0.12.7" declaration.

packages/opentelemetry-instrumentation-vertexai/pyproject.toml (1)

34-34: Same Ruff-version concern as noted for the CrewAI package

See earlier comment about upgrading / deduplicating the ruff = "^0.12.7" declaration.

packages/opentelemetry-instrumentation-bedrock/pyproject.toml (1)

34-36: Same observation as above

See previous comment about verifying the repo is fully cleansed of flake8 / autopep8 remnants.

packages/opentelemetry-instrumentation-openai-agents/pyproject.toml (1)

29-32: Same observation as above

packages/opentelemetry-instrumentation-chromadb/pyproject.toml (1)

32-35: Same observation as above

packages/opentelemetry-instrumentation-milvus/pyproject.toml (1)

32-35: Same observation as above

packages/sample-app/pyproject.toml (1)

100-103: Same Ruff version-range concern as in traceloop-sdk

For consistency & reproducibility, apply the same pinning / lock-file strategy discussed for the SDK package.

packages/opentelemetry-instrumentation-marqo/project.json (2)

49-55: Duplicate of the earlier comment: please ensure the ruff-check executor is available and that CI is updated accordingly.

---

78-85: Same observation on redundant lint:fix target – consider relying on the --fix flag instead of per-package duplication.

packages/opentelemetry-instrumentation-sagemaker/project.json (2)

49-55: Duplicate of the earlier comment about verifying executor availability and CI integration.

---

78-85: Duplicate of the earlier suggestion to drop the extra lint:fix target in favour of --fix.

packages/opentelemetry-instrumentation-groq/project.json (2)

49-55: Duplicate of the earlier comment about confirming ruff-check executor presence.

---

78-85: Duplicate of the earlier suggestion regarding redundant lint:fix targets.

packages/traceloop-sdk/project.json (2)

49-55: Duplicate of the earlier comment – confirm executor availability and CI configuration.

---

78-85: Duplicate of the earlier suggestion to avoid per-package lint:fix targets.

packages/opentelemetry-instrumentation-ollama/project.json (2)

48-56: Same glob-scope concern as the Pinecone package.
See previous comment; restricting lintFilePatterns improves speed and avoids touching generated paths.

---

78-86: Consider target defaults to remove duplication.
See detailed suggestion in Pinecone project.json.

packages/opentelemetry-semantic-conventions-ai/project.json (2)

48-56: Ruff lint glob could be tightened.
Refer to earlier comment; scanning the entire package tree might be unnecessary.

---

68-76: Duplicated lint vs lint:fix blocks.
Same DRY recommendation as given for Pinecone.

packages/opentelemetry-instrumentation-crewai/project.json (2)

48-56: Broad lint glob – optional refinement.
See prior comments.

---

78-86: Reduce config duplication via Nx defaults.
Same as previous.

packages/opentelemetry-instrumentation-cohere/project.json (2)

48-56: Wide **/*.py glob – consider narrowing.
See initial comment for justification.

---

78-86: Repeated target configuration.
Refer to DRY suggestion in Pinecone file.

packages/opentelemetry-instrumentation-together/project.json (1)

49-55: Same concern as raised in the MCP project – please ensure the option keys match the executor’s schema

packages/opentelemetry-instrumentation-alephalpha/project.json (1)

49-55: Same concern as raised in the MCP project – please ensure the option keys match the executor’s schema

packages/opentelemetry-instrumentation-google-generativeai/project.json (1)

49-55: Same concern as raised in the MCP project – please ensure the option keys match the executor’s schema

packages/opentelemetry-instrumentation-weaviate/project.json (1)

49-55: Same concern as raised in the MCP project – please ensure the option keys match the executor’s schema

packages/opentelemetry-instrumentation-mistralai/project.json (1)

49-55: Same Ruff-executor concern applies

See the comment in opentelemetry-instrumentation-replicate/project.json about pinning the Ruff version and ensuring the executor is available.

packages/opentelemetry-instrumentation-qdrant/project.json (1)

49-55: Same Ruff-executor concern applies

See the comment in opentelemetry-instrumentation-replicate/project.json about pinning the Ruff version and ensuring the executor is available.

packages/opentelemetry-instrumentation-vertexai/project.json (1)

49-55: Same Ruff-executor concern applies

See the comment in opentelemetry-instrumentation-replicate/project.json about pinning the Ruff version and ensuring the executor is available.

packages/opentelemetry-instrumentation-anthropic/project.json (1)

49-55: Same Ruff-executor concern applies

See the comment in opentelemetry-instrumentation-replicate/project.json about pinning the Ruff version and ensuring the executor is available.

packages/opentelemetry-instrumentation-haystack/project.json (1)

78-85: Apply the same scoped pattern to lint:fix

Mirror the change above so the auto-fix target only rewrites files inside this package.

-        "lintFilePatterns": [
-          "**/*.py"
-        ],
+        "lintFilePatterns": [
+          "{projectRoot}/**/*.py"
+        ],

packages/opentelemetry-instrumentation-openai/project.json (2)

49-55: Same glob-scope concern as noted for haystack

Please scope lintFilePatterns to {projectRoot}/**/*.py to avoid linting the whole repo from each package target.

---

78-85: Propagate the scoped pattern to lint:fix

Update the auto-fix target accordingly.

packages/opentelemetry-instrumentation-bedrock/project.json (2)

49-55: Scope the lint glob to this package

Replace "**/*.py" with {projectRoot}/**/*.py for faster, isolated lint runs.

---

78-85: Do the same for the fix target

Keep the glob consistent with the regular lint target.

packages/opentelemetry-instrumentation-lancedb/project.json (2)

49-55: Limit linting to package files

Please update the glob to {projectRoot}/**/*.py.

---

78-85: Align lint:fix glob with the change above

Avoid repo-wide writes during auto-fixing.

packages/opentelemetry-instrumentation-langchain/project.json (2)

49-55: Use a package-scoped glob for linting

Same performance concern as the other packages.

-        "lintFilePatterns": [
-          "**/*.py"
-        ],
+        "lintFilePatterns": [
+          "{projectRoot}/**/*.py"
+        ],

---

78-85: Update lint:fix glob accordingly

Keep fix behaviour consistent with lint behaviour.

packages/opentelemetry-instrumentation-watsonx/project.json (2)

49-55: Same duplication comment as on the milvus package.

Reuse an nx target default for the ruff-check configuration to keep per-package files minimal.

---

79-85: Disable caching for the fixer, as noted in the milvus review.

packages/opentelemetry-instrumentation-openai-agents/project.json (2)

49-55: Same duplication comment as on the milvus package.

---

79-85: Disable caching for the fixer, as noted in the milvus review.

packages/opentelemetry-instrumentation-llamaindex/project.json (2)

49-55: Same duplication comment as on the milvus package.

---

79-85: Disable caching for the fixer, as noted in the milvus review.

packages/opentelemetry-instrumentation-groq/pyproject.toml (1)

28-32: Confirm Ruff version constraint – it locks the project to an outdated minor line

^0.12.7 restricts upgrades to <0.13.0, preventing adoption of the much-newer 0.4.x feature set (rename-rule support, formatter, etc.).
If there’s no hard compatibility concern, consider widening the range:

-[tool.poetry.group.dev.dependencies]
-ruff = "^0.12.7"
+[tool.poetry.group.dev.dependencies]
+# Allow any post-0.4 feature releases up to the eventual 1.0.
+ruff = ">=0.4,<1.0"

Otherwise document why an older pin is required.

packages/opentelemetry-instrumentation-weaviate/pyproject.toml (1)

32-36: Ruff pin mirrors other packages – keep versions in sync via a shared constraint

Multiple sub-packages now carry identical ruff = "^0.12.7" pins. To avoid future drift, define the dev-dependency once in the workspace’s root pyproject.toml (using [tool.poetry.group.dev.dependencies]) or a poetry-plugin-group and inherit it, instead of duplicating in every package stanza.
This lowers maintenance and guarantees all packages lint with the same rule-set.

packages/opentelemetry-instrumentation-ollama/pyproject.toml (1)

28-32: Missing [tool.ruff] configuration block

The package adds Ruff but no config section is present locally; if the repository relies on a central config, ensure Ruff is invoked from repository root in CI/pre-commit.
If per-package overrides are needed (e.g., target-specific excludes), add:

[tool.ruff]
select = ["E", "F", "I"]
ignore = []

so contributors can run poetry run ruff . inside the package directory without unexpected defaults.

packages/opentelemetry-instrumentation-marqo/pyproject.toml (1)

32-36: Consider aligning semantic-versioning caret usage across all deps

For pytest you use the modern ^8.2.2 (major-level openness), whereas Ruff is limited to its micro-line. Decide on a consistent policy (e.g., open minors for tools, pinned patch for runtime libs) and document it in CONTRIBUTING to avoid confusion.

packages/opentelemetry-instrumentation-lancedb/pyproject.toml (1)

32-35: Consolidate the duplicated Ruff version across packages

ruff = "^0.12.7" is now hard-coded in every instrumentation package. That creates >20 duplicated version strings that must be kept in sync.
Consider moving the dev-dependency to a single, shared location (e.g. a root-level pyproject.toml “tool.poetry.group.dev.dependencies” or a top-level requirements file consumed via Poetry’s [tool.poetry.group] inherit-from) and letting the individual packages inherit it. This avoids drift and guarantees the Nx / Husky workflow always runs the same Ruff version everywhere.

packages/opentelemetry-instrumentation-langchain/pyproject.toml (1)

32-35: Pinning to caret ^0.12.7 may break unexpectedly

Ruff still ships breaking changes in minor versions (<1.0). Using ^0.12.7 allows any 0.12.x but also blocks 0.13.0+, which may contain security fixes or new rule IDs referenced in the repo-wide config.
Recommend either

ruff = "~0.12.7"   # stay on patch updates only  

or drop the version pin and rely on lockfiles/Dependabot.

packages/opentelemetry-instrumentation-alephalpha/pyproject.toml (1)

32-35: Add a [tool.ruff] section to silence rule collisions

The switch to Ruff enables all default rules, which can surface thousands of warnings the codebase previously ignored under Flake8’s config. Adding a minimal [tool.ruff] block (extend-select / extend-ignore) keeps the migration noise manageable and lets teams gradually adopt stricter rules.

packages/opentelemetry-instrumentation-transformers/project.json (1)

78-86: Add outputs for the lint:fix target (optional)

Unlike build, the lint:fix target currently has no declared outputs.
Declaring something like "outputs": [] (or a report directory) lets Nx cache
results and skip re-execution when nothing changed. Not mandatory but improves
workspace performance.

packages/sample-app/project.json (1)

68-76: Missing outputs on lint:fix (same as transformers package)

For caching parity across targets, consider declaring an empty or report
outputs array here as well.

packages/opentelemetry-instrumentation-chromadb/project.json (1)

78-85: Avoid per-package lint:fix targets; rely on the --fix flag instead

Nx already lets you run nx lint <project> --fix. Duplicating a lint:fix target in every project.json adds ~100-lines of boilerplate across the mono-repo and increases maintenance overhead.

Unless there is a strong reason (e.g. enforced by lint-staged) prefer:

"scripts": {
  "lint": "nx run-many --target=lint",
  "lint:fix": "nx run-many --target=lint --fix"   // single global alias
}

packages/opentelemetry-instrumentation-pinecone/project.json (1)

48-56: lint target looks good – consider narrowing the glob.

"lintFilePatterns": ["**/*.py"] will traverse every Python file under the package directory, including tests, build artefacts, and potentially large vendored folders. Ruff’s performance is great, but on big repos this still hurts incremental CI times.

If the intent is to lint only source + tests, prefer a scoped pattern:

-        "lintFilePatterns": [
-          "**/*.py"
-        ],
+        "lintFilePatterns": [
+          "opentelemetry/**/*.py",
+          "tests/**/*.py"
+        ],

Same advice applies to the new lint:fix target below.

packages/opentelemetry-instrumentation-replicate/project.json (1)

78-85: Reduce boilerplate via targetDefaults

lint:fix is now copy-pasted to every package. Nx supports targetDefaults in the root nx.json where you could define this once:

{
  "targetDefaults": {
    "lint":  { "executor": "@nxlv/python:ruff-check", "options": { "lintFilePatterns": ["**/*.py"], "fix": false } },
    "lint:fix": { "executor": "@nxlv/python:ruff-check", "options": { "lintFilePatterns": ["**/*.py"], "fix": true } }
  }
}

All projects inherit the default, eliminating duplication across ~30 project.json files and reducing maintenance overhead.

packages/opentelemetry-instrumentation-milvus/project.json (1)

49-55: Consider creating a single reusable executor configuration instead of duplicating per-package JSON.

The switch to @nxlv/python:ruff-check is correct, but every package now repeats the same lint block. You can reduce boilerplate (and the maintenance burden when options change) by:

1. Defining a named target in nx.json’s targetDefaults (or a custom preset) with the common executor/options.
2. Referencing it in each package via "dependsOn": ["^lint"] or simply letting the default kick in.

This keeps all ruff-specific flags centralised and avoids subtle drift across dozens of project.json files.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/sample-app/pyproject.toml (1)

100-105: Add a global Ruff configuration or confirm default behavior

I ran searches across the repo and did not find any [tool.ruff] section in any TOML file, nor a standalone ruff.toml. Without a project-level config, Ruff will fall back to its built-in defaults—which likely differ from your previous Flake8 settings (e.g. max-line-length, ignored error codes).

Please address:

• packages/sample-app/pyproject.toml (lines 100–105): you’ve added Ruff as a dev dependency but haven’t defined its rules here.
• Root of the repo: add a [tool.ruff] table to pyproject.toml or create a ruff.toml with your desired configuration.
• (Optional) If different rules are needed per package, introduce package-specific overrides under each pyproject.toml.

package.json (1)

5-9: prepare still runs bare husky – should be husky install

The Husky CLI prints help and exits when invoked without the install argument, so hooks are never set up.
Same issue was flagged previously.

-    "prepare": "husky",
+    "prepare": "husky install",

package.json (1)

20-22: Minor: avoid npx overhead inside lint-staged cmd

Since nx is already a dev dependency, lint-staged can execute it directly via the local binary, eliminating the npx spawn cost.

-    "**/*.py": "npx nx affected --target=lint:fix"
+    "**/*.py": "nx affected --target=lint:fix"

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/opentelemetry-instrumentation-langchain/tests/test_llms.py.bak (1)

1-1695: Remove backup file from the repository.

This .bak file appears to be a backup and should not be committed to version control. Please remove it and add *.bak to your .gitignore if not already present.

packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py.bak (1)

150-159: Remove backup files and add missing trailing newline

The test directory contains both active .py files and their .py.bak counterparts. The .bak files aren’t picked up by pytest and should be removed to avoid confusion. Also, add the missing newline at the end of the active test file for consistency.

• Delete the checked-in backup file:

• packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py.bak
• (Also remove any other *.py.bak test files, e.g. test_llms.py.bak.)
  • In the active test file, ensure there’s a newline at end of file:

--- a/packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py
+++ b/packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py
@@264,3 +264,4 @@ def assert_message_in_logs(log: LogData, event_name: str, expected_content:
     else:
         assert log.log_record.body
         assert dict(log.log_record.body) == expected_content
+

packages/traceloop-sdk/traceloop/sdk/client/__init__.py (1)

1-1: Redundant self-aliasing; expose via __all__ instead

Aliasing a symbol to itself adds noise without functional benefit. Re-exporting is clearer (and Ruff-friendly) when you import the symbol normally and list it in __all__.

-from .client import Client as Client
+from .client import Client
+
+__all__ = ["Client"]

packages/traceloop-sdk/traceloop/sdk/tracing/__init__.py (1)

1-2: Use relative imports & drop self-aliases; add __all__

Relative imports keep the package resilient to rename/refactor, and omitting the redundant as ... declutters the file. Listing exports in __all__ makes the intent explicit.

-from traceloop.sdk.tracing.context_manager import get_tracer as get_tracer
-from traceloop.sdk.tracing.tracing import set_workflow_name as set_workflow_name
+from .context_manager import get_tracer
+from .tracing import set_workflow_name
+
+__all__ = ["get_tracer", "set_workflow_name"]

packages/opentelemetry-instrumentation-anthropic/opentelemetry/instrumentation/anthropic/span_utils.py (1)

27-27: Consider improving readability by avoiding double negatives.

While the logic is correct, the double negative makes it harder to understand. Consider this more readable alternative:

-    return not (item.get("type") != "image" or item["source"].get("type") != "base64")
+    return item.get("type") == "image" and item["source"].get("type") == "base64"

packages/opentelemetry-instrumentation-mistralai/opentelemetry/instrumentation/mistralai/event_emitter.py (1)

57-57: Consider f-string conversion for consistency.

While the current .format() usage is functional, converting to f-string syntax (like f"gen_ai.{event.role}.message") would align with the modernization applied to other instrumentation packages in this PR.

-        name = "gen_ai.{}.message".format(event.role)
+        name = f"gen_ai.{event.role}.message"

packages/opentelemetry-instrumentation-langchain/tests/test_lcel.py (1)

470-473: Fix continuation line indentation.

The static analysis correctly identifies indentation issues with continuation lines. The continuation lines should be properly aligned.

Apply this diff to fix the indentation:

-    assert [span.name for span in spans] == ["PromptTemplate.task",
-        "ChatOpenAI.chat",
-        "StrOutputParser.task",
-        "RunnableSequence.workflow",]
+    assert [span.name for span in spans] == [
+        "PromptTemplate.task",
+        "ChatOpenAI.chat", 
+        "StrOutputParser.task",
+        "RunnableSequence.workflow",
+    ]

Also applies to: 498-501, 540-543, 580-583, 611-614, 657-660, 694-697, 723-726, 766-769

packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py (1)

56-58: Fix continuation line indentation.

The list literal format is cleaner, but the continuation lines need proper indentation as flagged by static analysis.

Apply this diff to fix the indentation:

-    assert [span.name for span in spans] == ["ChatCohere.chat",
-        "LLMChain.task",
-        "stuff_chain.workflow",]
+    assert [span.name for span in spans] == [
+        "ChatCohere.chat",
+        "LLMChain.task", 
+        "stuff_chain.workflow",
+    ]

Also applies to: 91-93, 135-137

packages/opentelemetry-instrumentation-langchain/tests/test_documents_chains.py.bak (3)

56-58: Improve assertion formatting for better readability.

The list assertion spans multiple lines inconsistently. Consider formatting it more cleanly.

-    assert [span.name for span in spans] == ["ChatCohere.chat",
-        "LLMChain.task",
-        "stuff_chain.workflow",]
+    assert [span.name for span in spans] == [
+        "ChatCohere.chat",
+        "LLMChain.task", 
+        "stuff_chain.workflow"
+    ]

---

91-93: Improve assertion formatting for consistency.

Same formatting issue as in the previous test - consider consistent multi-line formatting.

-    assert [span.name for span in spans] == ["ChatCohere.chat",
-        "LLMChain.task",
-        "stuff_chain.workflow",]
+    assert [span.name for span in spans] == [
+        "ChatCohere.chat",
+        "LLMChain.task",
+        "stuff_chain.workflow"
+    ]

---

135-137: Improve assertion formatting for consistency.

Same formatting issue - maintain consistent formatting across all tests.

-    assert [span.name for span in spans] == ["ChatCohere.chat",
-        "LLMChain.task",
-        "stuff_chain.workflow",]
+    assert [span.name for span in spans] == [
+        "ChatCohere.chat",
+        "LLMChain.task",
+        "stuff_chain.workflow"
+    ]